xfs
[Top] [All Lists]

Re: [PATCH v2 05/10] xfs: fix error handling in xfs_bulkstat

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2 05/10] xfs: fix error handling in xfs_bulkstat
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 23:48:15 -0700
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <535078B8.4020905@xxxxxxxxxx>
References: <535078B8.4020905@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> Moreover, this fix also get rid of the redundant user buffer count
> pre-checkups as it has already been validated in upper callers.

> -     if (!ubcountp || *ubcountp <= 0) {
> -             return EINVAL;
> -     }

Probably better to have this as a separate patch.

> -                     /*
> -                      * Loop as long as we're unable to read the
> -                      * inode btree.
> -                      */
> -                     while (error) {
> -                             agino += XFS_INODES_PER_CHUNK;
> -                             if (XFS_AGINO_TO_AGBNO(mp, agino) >=
> -                                             be32_to_cpu(agi->agi_length))
> -                                     break;
> -                             error = xfs_inobt_lookup(cur, agino,
> -                                                      XFS_LOOKUP_GE, &tmp);
> -                             cond_resched();
> -                     }

This code goes back to 1995, but I still can't see how it would make
sense.  I think we should get rid of this, but I'd also love to have
Dave and Eric double check it as well.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>