xfs
[Top] [All Lists]

Re: [PATCH] xfstests: introduce FSX_AVOID env var

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: introduce FSX_AVOID env var
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 23:31:53 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5355478C.8070905@xxxxxxxxxx>
References: <5355478C.8070905@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 21, 2014 at 11:30:04AM -0500, Eric Sandeen wrote:
> Just like FSSTRESS_AVOID, FSX_AVOID can be used to add
> options at the end of the default fsx runs in each test.
> i.e. FSX_AVOID="-H -z -C" will disable punch hole, zero range,
> and collapse range calls in all tests which run fsx.
> 
> This should handle Ted's concerns about buggy ext4 fallocate
> code without needing to add tunables to the kernel to reject
> these operations during xfstests runs.

I would much prefer to add a little _run_fsx helper to encapsulate this.

<Prev in Thread] Current Thread [Next in Thread>