xfs
[Top] [All Lists]

Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 22:40:21 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, XFS Mailing List <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53597B34.9050407@xxxxxxx>
References: <20140423210034.892939354@xxxxxxx> <20140423210445.700477624@xxxxxxx> <20140423222215.GT18672@dastard> <535945DC.6010108@xxxxxxx> <53597B34.9050407@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 24, 2014 at 03:59:32PM -0500, Mark Tinguely wrote:
> PS. I may not have been very clear, the libxfs_trans_roll() and
>     inode_item_done() also cause a premature libxfs_iput().
>     Let me do more testing making any changes and target this for
>     xfsprogs-3.2.1.

You mean you've fixed the way we handle the attachement of inodes to
transaction in userspace to mirror what we do in kernelspace?  I'd love
to review this if you have patches as it's a somewhat of a pain point
to have these work so different in kernel and userspace.

<Prev in Thread] Current Thread [Next in Thread>