[Top] [All Lists]

Re: [PATCH 3/6 v2] generic: introduce new large ACL test

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6 v2] generic: introduce new large ACL test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 22:36:48 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140423234452.GW15995@dastard>
References: <1398204274-2113-1-git-send-email-david@xxxxxxxxxxxxx> <1398204274-2113-4-git-send-email-david@xxxxxxxxxxxxx> <20140423152313.GC26128@xxxxxxxxxxxxx> <20140423230915.GV15995@dastard> <20140423234452.GW15995@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 24, 2014 at 09:44:53AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Having just removed the largeacl test from the shared ACL test,
> reintroduce the same test as an generic test so that we can
> handle the different limits in supported ACL count appropriately
> across different filesystems and different configurations within
> filesystem types.
> Filesystems have to add support to _acl_get_max to run
> this test - the default behaviour right now is to throw a
> notrun error like this:
> generic/026 14s ... [not run] ext4 does not define maximum ACL count
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>