xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Use _require_xfs_io_command() instead of helpers

To: Lukas Czerner <lczerner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: Use _require_xfs_io_command() instead of helpers
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 24 Apr 2014 11:55:43 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1398355303-29348-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1398355303-29348-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/24/14, 11:01 AM, Lukas Czerner wrote:
> Number of helpers for checking xfs_io functionality is slowly growing.
> But it's as easy to simply use _require_xfs_io_command() directly and
> just specify the command we want to check. It will also avoid the need
> to create helper every time we need to check a new command in xfs_io.
> 
> Remove all the helpers and use _require_xfs_io_command() in the tests.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

I like it.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>