xfs
[Top] [All Lists]

Re: [PATCH v5 03/11] xfs: support the XFS_BTNUM_FINOBT free inode btree

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v5 03/11] xfs: support the XFS_BTNUM_FINOBT free inode btree type
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Thu, 24 Apr 2014 07:28:22 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140424052722.GZ15995@dastard>
References: <1397146116-42546-1-git-send-email-bfoster@xxxxxxxxxx> <1397146116-42546-4-git-send-email-bfoster@xxxxxxxxxx> <20140424052722.GZ15995@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 24, 2014 at 03:27:22PM +1000, Dave Chinner wrote:
> On Thu, Apr 10, 2014 at 12:08:28PM -0400, Brian Foster wrote:
> > Define the AGI fields for the finobt root/level and add magic
> > numbers. Update the btree code to add support for the new
> > XFS_BTNUM_FINOBT inode btree.
> > 
> > The finobt root block is reserved immediately following the inobt
> > root block in the AG. Update XFS_PREALLOC_BLOCKS() to determine the
> > starting AG data block based on whether finobt support is enabled.
> > 
> > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> 
> Looks good.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> FWIW, xfstests doesn't give us particularly good coverage of all
> the finobt operations:
> 
> $ $ grep fibt /proc/fs/xfs/stat 
> fibt2 43617 50359 338 336 0 0 0 0 0 0 0 0 0 0 136
> 
> So perhaps we want to look at improving that over time.
> 

Ok, noted. I'll have to think about some tests tailored to exercise the
finobt.

Brian

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>