xfs
[Top] [All Lists]

Re: [PATCH v5 08/11] xfs: update the finobt on inode free

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v5 08/11] xfs: update the finobt on inode free
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 15:47:50 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397146116-42546-9-git-send-email-bfoster@xxxxxxxxxx>
References: <1397146116-42546-1-git-send-email-bfoster@xxxxxxxxxx> <1397146116-42546-9-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 10, 2014 at 12:08:33PM -0400, Brian Foster wrote:
> An inode free operation can have several effects on the finobt. If
> all inodes have been freed and the chunk deallocated, we remove the
> finobt record. If the inode chunk was previously full, we must
> insert a new record based on the existing inobt record. Otherwise,
> we modify the record in place.
> 
> Create the xfs_difree_finobt() function to identify the potential
> scenarios and update the finobt appropriately.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

No problems there that I can see.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>