xfs
[Top] [All Lists]

Re: [PATCH v5 06/11] xfs: use and update the finobt on inode allocation

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v5 06/11] xfs: use and update the finobt on inode allocation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 15:44:28 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397146116-42546-7-git-send-email-bfoster@xxxxxxxxxx>
References: <1397146116-42546-1-git-send-email-bfoster@xxxxxxxxxx> <1397146116-42546-7-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 10, 2014 at 12:08:31PM -0400, Brian Foster wrote:
> Replace xfs_dialloc_ag() with an implementation that looks for a
> record in the finobt. The finobt only tracks records with at least
> one free inode. This eliminates the need for the intra-ag scan in
> the original algorithm. Once the inode is allocated, update the
> finobt appropriately (possibly removing the record) as well as the
> inobt.
> 
> Move the original xfs_dialloc_ag() algorithm to
> xfs_dialloc_ag_inobt() and fall back as such if finobt support is
> not enabled.

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>