xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: introduce new large ACL test

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: introduce new large ACL test
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Apr 2014 09:09:15 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140423152313.GC26128@xxxxxxxxxxxxx>
References: <1398204274-2113-1-git-send-email-david@xxxxxxxxxxxxx> <1398204274-2113-4-git-send-email-david@xxxxxxxxxxxxx> <20140423152313.GC26128@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 23, 2014 at 08:23:13AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 23, 2014 at 08:04:31AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Having just removed the largeacl test from the shared ACL test,
> > reintroduce the same test as an XFS specific test so that we can
> > handle the different limits in supported ACL count appropriately.
> 
> I'd prefer to have this as a shared test, and define a _max_acl_size
> function in common.acl that does a switch for the fs type.  Only
> start with XFS for now, but if the maintainers of other filesystems
> care enough they could add their limits.

Ok, I'll add it as a generic test, along with a _max_acl_size
function and a _requires_max_acl_size helper....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>