xfs
[Top] [All Lists]

Re: [PATCH v3 00/20] xfsprogs: introduce the free inode btree

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 00/20] xfsprogs: introduce the free inode btree
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Wed, 23 Apr 2014 16:02:32 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140423063559.GQ15995@dastard>
References: <1397146270-42993-1-git-send-email-bfoster@xxxxxxxxxx> <20140423063559.GQ15995@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 23, 2014 at 04:35:59PM +1000, Dave Chinner wrote:
> On Thu, Apr 10, 2014 at 12:10:50PM -0400, Brian Foster wrote:
> > Hi all,
> > 
> > This is the v3 userspace portion of finobt support corresponding to v5
> > of the kernel series.
> > 
> > Patches 1-10 are straight application of the corresponding kernel patches
> > with omissions where appropriate.
> 
> I haven't done anything more than passed a quick eye over them and
> tested them. I'll review them fully in the kernel context, and we
> can apply any changes to the kernel code directly to them...
> 

Ok...

> > Patch 11 adds mkfs support. Patches 12 and 13 provide a couple minor db
> > and repair fixes to support the new agi fields and calculate the fs
> > format respectively. Patches 14-18 add real repair support for the
> > finobt. Patch 19 adds support to report finobt state in xfs_info. Patch
> > 20 adds support for metadump.
> > 
> > Thoughts, reviews, flames appreciated.
> 
> I've made comments on the patches that i think need a bit of work,
> but all the remainder (11-20) I haven't made any direct comment on
> you can consider:
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 

Sounds good. Thanks for the reviews! :)

Brian

> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>