xfs
[Top] [All Lists]

Re: [PATCH v3 11/20] xfsprogs/mkfs: finobt mkfs support

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 11/20] xfsprogs/mkfs: finobt mkfs support
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Wed, 23 Apr 2014 16:01:36 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140423060352.GL15995@dastard>
References: <1397146270-42993-1-git-send-email-bfoster@xxxxxxxxxx> <1397146270-42993-12-git-send-email-bfoster@xxxxxxxxxx> <20140423060352.GL15995@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 23, 2014 at 04:03:53PM +1000, Dave Chinner wrote:
> On Thu, Apr 10, 2014 at 12:11:01PM -0400, Brian Foster wrote:
> > Add the 'finobt' metadata option to mkfs to format an fs with free
> > inode btree support. If enabled, initialize the associated AGI
> > header fields and btree root block.
> > 
> > Also, do the initialization of the superblock version and feature
> > bits (including the new finobt flag) a bit earlier. These fields
> > must now be initialized prior to the use of XFS_PREALLOC_BLOCKS(),
> > as the latter returns a value that depends on whether a finobt root
> > btree block is reserved.
> > 
> > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> 
> $ sudo mkfs.xfs -f -mcrc=1,finobt=1 -m crc=0 -d size=128m /dev/ram1
> meta-data=/dev/ram1              isize=256    agcount=4, agsize=8192 blks
>          =                       sectsz=512   attr=2, projid32bit=1
>        =                       crc=0        finobt=1
>                                ^^^^^        ^^^^^^^^
> .....
> $ mount /dev/ram1 /mnt/scratch
> [ 4727.269080] XFS (ram1): Mounting Filesystem
> [ 4727.270077] XFS (ram1): Log inconsistent or not a log (last==0, first!=1)
> [ 4727.271227] XFS (ram1): empty log check failed
> [ 4727.271970] XFS (ram1): log mount/recovery failed: error 22
> [ 4727.273097] XFS (ram1): log mount failed
> 
> If "-mcrc=0" is seen on the command line, it needs to turn off
> finobt....
> 
> xfs/001 and xfs/002 trip over this when run like:
> 
> $ MKFS_OPTIONS="-mcrc=1,finobt=1" ./check xfs/00[12]
> 
> Otherwise, everything seems to be working ;)
> 

Yeah, I've hit this. Which reminds me... I should probably detect this
and fail outright in mkfs as well.

Brian

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>