[Top] [All Lists]

Re: [PATCH 5/6] xfs: remove dmapi tests from the auto group

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfs: remove dmapi tests from the auto group
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 08:24:44 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1398204274-2113-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1398204274-2113-1-git-send-email-david@xxxxxxxxxxxxx> <1398204274-2113-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 23, 2014 at 08:04:33AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> There is no mainline kernel support for DMAPI in XFS, and so every
> time the xfstests auto group is run it throws a large number of
> "[not run] Assuming DMAPI modules are not loaded". I've noted that
> people are excluding the dmapi group to avoid this, so rather than
> inflict pain on everyone, make hose few that need to do dmapi
> testing include it specifically.
> IOWs, remove the DMAPI tests from the auto group.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Yes, we shouldn't run them by default.  They also probably should move
from the tests/xfs/ dir to a new tests/dmapi one as they aren't really
XFS specific, they are specific to the out of tree dmapi code which
at one point could also support JFS.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>