[Top] [All Lists]

Re: [PATCH 1/6] generic/204: tweak reserve pool size

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] generic/204: tweak reserve pool size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 08:21:46 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1398204274-2113-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1398204274-2113-1-git-send-email-david@xxxxxxxxxxxxx> <1398204274-2113-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 23, 2014 at 08:04:29AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> On small block size filesystems, the reserve pool size is kept
> constant at 4MB. filesystems with smaller blocks use comparitively
> more blocks for indexing metadata (e.g. in the inode and extent
> btrees) and so having a higher indirect block usage. Hence we need
> to leave the reserve pool at 1024 block and not scale it for a
> constant size.
> This makes the test pass on a filesystem made with MKFS_OPTIONS="-b
> size=1024 -m crc=1".

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>