xfs
[Top] [All Lists]

Re: [PATCH] xfs: remote attribute overwrite causes transaction overrun

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: remote attribute overwrite causes transaction overrun
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 15:54:17 +1000
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53572DDA.8080302@xxxxxxxxxxx>
References: <1398149949-11324-1-git-send-email-david@xxxxxxxxxxxxx> <535659F7.4060702@xxxxxxxxxx> <20140422234628.GN18672@dastard> <20140423000042.GO18672@dastard> <53572DDA.8080302@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 22, 2014 at 10:04:58PM -0500, Eric Sandeen wrote:
> On 4/22/14, 7:00 PM, Dave Chinner wrote:
> > On Wed, Apr 23, 2014 at 09:46:28AM +1000, Dave Chinner wrote:
> >> On Tue, Apr 22, 2014 at 08:00:55PM +0800, Jeff Liu wrote:
> >>>
> >>> On 04/22 2014 14:59 PM, Dave Chinner wrote:
....
> >>>> +        /* remote value might be different size to the buffer supplied. 
> >>>> */
> >>>> +        if (args->rmtvaluelen = args->valuelen)
> >>>                        ^^^
> >>> Here is a typo...
> >>
> >> Oh, well spotted.
> >>
> >> But, hold on a minute, shouldn't gcc be catching those sorts of
> >> typos?
....
> > Time to add ccflags-y += -Werror to the makefile....
> 
> Probably only under a couple specific arches...?  How are we for i.e.
> stupid printf format warnings about long vs. longlong on 32/64 arches...?
> 
> Or maybe you can -Werror, -Wno$FOO?

Personally, if other arches are throwing warnings that we don't know
about, they need to be fixed. The only way I'll get to know about
them is to have somebody else's build break, because nobody is
reporting warnings to us right now....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>