On 4/22/14, 7:00 PM, Dave Chinner wrote:
> On Wed, Apr 23, 2014 at 09:46:28AM +1000, Dave Chinner wrote:
>> On Tue, Apr 22, 2014 at 08:00:55PM +0800, Jeff Liu wrote:
>>> On 04/22 2014 14:59 PM, Dave Chinner wrote:
>>>> + /* remote value might be different size to the buffer supplied. */
>>>> + if (args->rmtvaluelen = args->valuelen)
>>> Here is a typo...
>> Oh, well spotted.
>> But, hold on a minute, shouldn't gcc be catching those sorts of
>> /me groans
>> $ gcc t.c
>> $ gcc -Wall t.c
>> t.c: In function ¿main¿:
>> t.c:10:2: warning: suggest parentheses around assignment used as truth value
>> if (foo = bar)
>> Only if -Wparentheses is specified.
>> Why the hell are we suppressing useful warnings on the kernel build?
> Hmmm - looks like I missed the output of the warning when I built
> against 3.15-rc2 because it was a rebuild the world and there's tons
> of output when that happens...
> Time to add ccflags-y += -Werror to the makefile....
Probably only under a couple specific arches...? How are we for i.e.
stupid printf format warnings about long vs. longlong on 32/64 arches...?
Or maybe you can -Werror, -Wno$FOO?