xfs
[Top] [All Lists]

Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 22 Apr 2014 10:56:19 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <535663CB.5080309@xxxxxxxxxx>
References: <53558354.5040309@xxxxxxxxxx> <20140422062736.GA31337@xxxxxxxxxxxxx> <535663CB.5080309@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/22/14, 7:42 AM, Jeff Liu wrote:
> 
> On 04/22 2014 14:27 PM, Christoph Hellwig wrote:
>> On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote:
>>> Coverity noticed that if we sent junk into
>>> xfs_qm_scall_trunc_qfiles(), we could get back an
>>> uninitialized error value.  So sanitize the flags we
>>> will accept, and initialize error anyway for good measure.
>>>
>>> (This bug may have been introduced via c61a9e39).
> 
> Indeed, my mistake.

No worries, it's a very small thing, and programatically
impossible.  Not trying to point fingers, just looking for
whether it's a new warning or an old one.

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>