xfs
[Top] [All Lists]

Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 22 Apr 2014 20:42:51 +0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140422062736.GA31337@xxxxxxxxxxxxx>
References: <53558354.5040309@xxxxxxxxxx> <20140422062736.GA31337@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 04/22 2014 14:27 PM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote:
>> Coverity noticed that if we sent junk into
>> xfs_qm_scall_trunc_qfiles(), we could get back an
>> uninitialized error value.  So sanitize the flags we
>> will accept, and initialize error anyway for good measure.
>>
>> (This bug may have been introduced via c61a9e39).

Indeed, my mistake.

>>
>> Should resolve Coverity CID 1163872.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me too.

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>