xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfstests: add helper for zero range support check

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 22 Apr 2014 19:46:12 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Eric Whitney <enwlinux@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1404221127240.7437@xxxxxxxxxxxxxxxxxxxxx>
References: <20140421204023.GB960@wallace> <20140422062816.GB31337@xxxxxxxxxxxxx> <20140422091443.GG15995@dastard> <20140422091620.GA4980@xxxxxxxxxxxxx> <alpine.LFD.2.00.1404221127240.7437@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 22, 2014 at 11:28:31AM +0200, LukÃÅ Czerner wrote:
> On Tue, 22 Apr 2014, Christoph Hellwig wrote:
> 
> > Date: Tue, 22 Apr 2014 02:16:20 -0700
> > From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> > To: Dave Chinner <david@xxxxxxxxxxxxx>
> > Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx,
> >     xfs@xxxxxxxxxxx, Eric Whitney <enwlinux@xxxxxxxxx>
> > Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
> > 
> > On Tue, Apr 22, 2014 at 07:14:43PM +1000, Dave Chinner wrote:
> > > I don't really care either way, as long as all the checks are done
> > > consistently. Send a patch to change them all... :)
> > 
> > My flink test already avoids the wrapper :)
> > 
> > So how about we stop adding them for now at least.
> 
> I agree,
> 
> even though I screwed up when using _require_xfs_io_command with
> fzero :) I think that we can avoid the wrappers and just use
> _require_xfs_io_command() with the command name.

Send patches ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>