xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfstests: add helper for zero range support check

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 22 Apr 2014 19:14:43 +1000
Cc: Eric Whitney <enwlinux@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140422062816.GB31337@xxxxxxxxxxxxx>
References: <20140421204023.GB960@wallace> <20140422062816.GB31337@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 21, 2014 at 11:28:16PM -0700, Christoph Hellwig wrote:
> > +# check that xfs_io, kernel, and filesystem all support fallocate with zero
> > +# range
> > +_require_xfs_io_falloc_zero()
> > +{
> > +   _require_xfs_io_command "fzero"
> > +}
> 
> I'd rather remove all the wrappers around _require_xfs_io_command, they
> don't actually add any value.

I don't really care either way, as long as all the checks are done
consistently. Send a patch to change them all... :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>