xfs
[Top] [All Lists]

Re: [PATCH] xfs: Fix wrong error codes being returned

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Fix wrong error codes being returned
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 22 Apr 2014 16:17:48 +0800
Cc: Tuomas Tynkkynen <tuomas.tynkkynen@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140421143629.GB4371@xxxxxxxxxxxxxx>
References: <1398074687-26548-1-git-send-email-tuomas.tynkkynen@xxxxxx> <5355132F.4070303@xxxxxxxxxx> <20140421130931.GB24813@xxxxxxxxxxxxxxx> <535524BE.7070704@xxxxxxxxxx> <20140421143629.GB4371@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 04/12 2014 22:36 PM, Brian Foster wrote:
> On Mon, Apr 21, 2014 at 10:01:34PM +0800, Jeff Liu wrote:
>>
>> On 04/21 2014 21:09 PM, Brian Foster wrote:
>>> On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote:
>>>> Hi Tuomas,
>>>>
>>>> On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote:
>>>>> xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect
>>>>> sign in some cases. While at it, make sure ENOMEM is returned instead of
>>>>> E2BIG if kmalloc fails.
>>>>>
>>>>> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@xxxxxx>
>>>>> ---
>>>>> Compile tested only. For the ERANGE case, I also wonder if it should
>>>>> be assigning to ops[i].am_error instead of error, and/or have a break.
>>>>
>>>> If I understand right, ops[i].am_error is used to save the internal 
>>>> operation result,
>>>> i.e, xfs_attrmult_attr_get{set}... but error is used for the ioctl call 
>>>> results.
>>>> Therefore, assign ERANGE to error is compatible with the VFS set{get}xattr 
>>>> syscalls in
>>>> case of "if (ops[i].am_error == 0 || ops[i].am_error == MAXNAMELEN)".
>>>>
>>>
>>> But we set 'error' in this case and effectively try to continue the 
>>> operation
>>> whereas the traditional vfs path returns...
>>
>> So the error would always be set to ERANGE if one or more attrname is/are 
>> invalid.
>>
> 
> Right...
> 
>>>
>>>> It seems that we don't need to have a break in this case because 
>>>> xfs_attrmulti_by_handle()
>>>> is used to process multiple attrs.  Hence if a given attrname in ops array 
>>>> is invalid,
>>>> the am_error will indicate that with ENOATTR or EFAULT...but it should 
>>>> proceed to loop
>>>> through the left array members.
>>>>
>>>
>>> Perhaps so if am_error == 0, but it depends on what attr_name contains
>>> at that point (stale data?). Otherwise, we try to proceed with a
>>> truncated name. It looks like the consistent thing to do would be set
>>> am_error to ERANGE and continue (i.e., skip the op and move on to the
>>> next).
>>
>> If we continue to process a truncated name in case of MAXNAMELEN, it would 
>> return
>> EFAULT for SET/REMOVE operations, and ENOATTR for GET operation, which would 
>> be
>> set back to am_error, but error still keep as ERANGE which is consistently.
>>
> 
> Ah, we should hit an error in the xfs_attr_name_to_xname() call
> deeper in the callchain, so the truncated name case should not be an
> issue. The am_error == 0 case still looks weird to me.

IMO am_error == 0 case means that the supplied attrname is NULL, and this would 
be
detected by xfs_attr_name_to_xname() as well, i.e,

if (!aname)
        return EINVAL;

> 
> So we return an error and set am_error if there's an issue with the attr
> name. 

But the am_error would be replaced with another errno if any operation
is failed thereafter, or 0 on success.  So the error is only used to indicate
the ioctl call status anyway.

> If there's another error in the op path, we set am_error only and
> continue on. Not being familiar with the interface, I'm curious if there
> is any particular reason for that difference in behavior. It seems like
> the caller should process all of the return codes anyways.

It seems to me that the design is convenient to the user space as the user could
get more precise call status for one/more particular attrname{s} operations.

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>