xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfstests: add helper for zero range support check

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Apr 2014 23:28:16 -0700
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140421204023.GB960@wallace>
References: <20140421204023.GB960@wallace>
User-agent: Mutt/1.5.21 (2010-09-15)
> +# check that xfs_io, kernel, and filesystem all support fallocate with zero
> +# range
> +_require_xfs_io_falloc_zero()
> +{
> +     _require_xfs_io_command "fzero"
> +}

I'd rather remove all the wrappers around _require_xfs_io_command, they
don't actually add any value.

<Prev in Thread] Current Thread [Next in Thread>