xfs
[Top] [All Lists]

Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Apr 2014 23:27:36 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53558354.5040309@xxxxxxxxxx>
References: <53558354.5040309@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote:
> Coverity noticed that if we sent junk into
> xfs_qm_scall_trunc_qfiles(), we could get back an
> uninitialized error value.  So sanitize the flags we
> will accept, and initialize error anyway for good measure.
> 
> (This bug may have been introduced via c61a9e39).
> 
> Should resolve Coverity CID 1163872.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>