Re: [PATCH] xfstests: generic/285: fix seek_sanity

xfs

Re: [PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK

To:	Konstantin Khlebnikov <k.khlebnikov@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject:	Re: [PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA
From:	Jeff Liu <jeff.liu@xxxxxxxxxx>
Date:	Tue, 22 Apr 2014 11:56:47 +0800
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140421164305.22404.92195.stgit@buzz>
References:	<20140421164305.22404.92195.stgit@buzz>
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 04/22 2014 00:43 AM, Konstantin Khlebnikov wrote:
> Generic implementation of SEEK_HOLE/DATA reports whole file as data chunk with
> virtual hole at the end (generic_file_llseek, used by ext2/ext3/reiserfs/nfs).
> 
> Currently test prepares file smaller than expected for "huge file" testcases
> (testcases 10-12). This patch fixes test file layout, now second data chunk
> ends right at the expected end of file.
> 
> Plus it fixes type of 'filesz' argument, it should be off_t.

Am not verified against NFS, but the fix look good to me.


Thanks,
-Jeff

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA, Konstantin Khlebnikov Re: [PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA, Jeff Liu <=

Previous by Date:	[PATCH] common: new function to get real device path name and basename, Eryu Guan
Next by Date:	Re: [PATCH] common: new function to get real device path name and basename, Dave Chinner
Previous by Thread:	[PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA, Konstantin Khlebnikov
Next by Thread:	[PATCH] xfstests: introduce FSX_AVOID env var, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]