xfs
[Top] [All Lists]

[PATCH v3 3/3] generic: fix check for zero range support in generic/009

To: xfs@xxxxxxxxxxx
Subject: [PATCH v3 3/3] generic: fix check for zero range support in generic/009
From: Eric Whitney <enwlinux@xxxxxxxxx>
Date: Mon, 21 Apr 2014 16:44:54 -0400
Cc: linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=974E+tb5Y7VTxcZjPk+1VQ5rab5r7YueEbTol3XM17o=; b=uUMgBR7ESQZ6IKQTkSSMVyXjRgJMdh8MewBnrubbR1GVRQkqlxxwVndPwQ+LS+ySvK jqdONPtngJ/w4ZXTMm/Z4IyK4XOBHjci7w9D9sfUrj2HGrfL3BAk6f99hbA+W86qYRhM jAVv9snuMCiwKGxBBroTzhO6wuEfUeXNY6fbpcFJpGuoL9kWQK1rfiyZoJkK7PM8fo9N B9Ags1uvkOen8/CkPar1tZU9YxAVx1wfadLySbZzpihd6ZBvzQ+fZhzMsOEbdUktmVlb te6JfGPh00ayKDiPzl6YZmFbXV0VwZUMvLnq9ZHJ5x3MOXp6S0NZukkhMmMT3f/bc9Fe r1TQ==
User-agent: Mutt/1.5.21 (2010-09-15)
Generic/001 fails when run on a file system that does not support byte range
zeroing.  For example, an EOPNOTSUPP failure occurs when the test is run
on a pre-3.15 extent-mapped file system.  The code in the test intended
to prevent this contains an apparent typo that results in a check for
fallocate() rather than zero range support.

v2: Use new helper function for the check.

Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
---
 tests/generic/009 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/009 b/tests/generic/009
index b7b0b3f..b4d3e4b 100644
--- a/tests/generic/009
+++ b/tests/generic/009
@@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 
 # real QA test starts here
 _supported_os Linux
-_require_xfs_io_falloc "fzero"
+_require_xfs_io_falloc_zero
 
 testfile=$TEST_DIR/009.$$
 
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH v3 3/3] generic: fix check for zero range support in generic/009, Eric Whitney <=