xfs
[Top] [All Lists]

[PATCH v2 2/3] ext4: fix check for zero range support in ext4/001

To: xfs@xxxxxxxxxxx
Subject: [PATCH v2 2/3] ext4: fix check for zero range support in ext4/001
From: Eric Whitney <enwlinux@xxxxxxxxx>
Date: Mon, 21 Apr 2014 16:43:09 -0400
Cc: linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=enJumf1toPtVCd/gi15I0+z0SZx5+WM9d8eQMgEVxUQ=; b=Vx1c5EXROXYBO7r/5lKlmwQ+ZMIz1hfmn7oSdHpfqnQubaLJ6GkXhH0AhJ1I2/HOj2 +JE9T2zWD3ZZ9dl/UnXbf02p5Vgj23eLkToAjD5c4LQQ2TkP41ooNlXvwjFY8WGnm+2J i7h1WE/3sDlDHVkadrvNZF5VyzyOUhQ+iZExIxWGVslFGIC15Ts+AwS5lO4TLDzFwOj1 I+p2YDmm4Sjx/S3KNyytct2AdW1A/BdeZuFRq1Q6aSa9uRwcb/4UOxrxFvLtiwzheFJ+ +5F4TUxPzd4mVDEf5+ELBUyZwt20IANN/hFv6UcY2fYK3gOClM+D4eWxNNg4aZrP3T7X Ntlw==
User-agent: Mutt/1.5.21 (2010-09-15)
Ext4/001 fails when run on a file system that does not support byte range
zeroing.  For example, an EOPNOTSUPP failure occurs when the test is run
on a pre-3.15 extent-mapped file system.  The code in the test intended
to prevent this contains an apparent typo that results in a check for
fallocate() rather than zero range support.

v2: Use new wrapper function for the check.

Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
---
 tests/ext4/001 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ext4/001 b/tests/ext4/001
index d575d9a..8239f0e 100755
--- a/tests/ext4/001
+++ b/tests/ext4/001
@@ -45,7 +45,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 # real QA test starts here
 _supported_fs ext4
 _supported_os Linux
-_require_xfs_io_falloc "fzero"
+_require_xfs_io_falloc_zero
 
 testfile=$TEST_DIR/001.$$
 
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH v2 2/3] ext4: fix check for zero range support in ext4/001, Eric Whitney <=