xfs
[Top] [All Lists]

Re: [PATCH] generic: fix check for zero range support in generic/009

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] generic: fix check for zero range support in generic/009
From: Eric Whitney <enwlinux@xxxxxxxxx>
Date: Mon, 21 Apr 2014 16:36:55 -0400
Cc: Eric Whitney <enwlinux@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=t8k4tBepI9lrHXD6CAVteO3fZgCTAxPBh0UTVUV4Q2w=; b=TeZph08dldZJoQbcMJX1qvcRistid/5jckODaF3TwSHOp5kENAVl32ig6Z0p6HZ2+/ uU0VAXaLLBHJxiblt7aae7cK15ux8Gp2OiyuuUZSIXdyQqiDgQKmQ7JXtcKQDKS574Be 39963h4DWp2h5sZlTjUMuQ7+pu05Lg/OJzZwDRqQEQBZEVjYVKLTD7Hd29jzYDL3uBaS VlAYfTueToz9ncGpRZ4wFM+FYeqqmr8iE0Md/g9mzPzCtd7A0drDlT5xVBikvWZ0xKku pyARgWTXyjo/U62rwQFEgugjjXzjfMaIJwCS/4U1gmQpS7Abl+98SjBDpZVQ40k+8H4o Uy0A==
In-reply-to: <20140420005645.GB15995@dastard>
References: <20140419190524.GA2116@wallace> <20140420005645.GB15995@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
* Dave Chinner <david@xxxxxxxxxxxxx>:
> On Sat, Apr 19, 2014 at 03:05:24PM -0400, Eric Whitney wrote:
> > Generic/001 fails when run on a file system that does not support byte range
> > zeroing.  For example, an EOPNOTSUPP failure occurs when the test is run
> > on a pre-3.15 extent-mapped file system.  The code in the test intended
> > to prevent this contains an apparent typo that results in a check for
> > fallocate() rather than zero range support.
> > 
> > Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
> > ---
> >  tests/generic/009 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/009 b/tests/generic/009
> > index b7b0b3f..65abe3c 100644
> > --- a/tests/generic/009
> > +++ b/tests/generic/009
> > @@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
> >  
> >  # real QA test starts here
> >  _supported_os Linux
> > -_require_xfs_io_falloc "fzero"
> > +_require_xfs_io_command "fzero"
> 
> There should be a helper in common/rc for this. i.e.
> _require_xfs_io_fzero. There's helpers for everything else. Can you
> add the helper and wire the tests up to it properly?
> 

Sure.  For naming consistency with the other related helper functions, it
looks like we'd want to call this _require_xfs_io_falloc_zero().  I'm happy
to change this if I'm mistaken.  Patches on the way.

Thanks,
Eric

<Prev in Thread] Current Thread [Next in Thread>