xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: return is not a function

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: return is not a function
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 20 Apr 2014 23:58:08 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <534EC173.7010903@xxxxxxxxxxx>
References: <534EC073.8090006@xxxxxxxxxxx> <534EC173.7010903@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 16, 2014 at 12:44:19PM -0500, Eric Sandeen wrote:
> return is not a function.  "return(EIO);" is silly;
> "return (EIO);" moreso.  return is not a function.
> Nuke the pointless parens.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>