Re: [PATCH 1/2] xfs: return is not a function

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs: return is not a function
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 20 Apr 2014 23:58:08 -0700
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<534EC173.7010903@xxxxxxxxxxx>
References:	<534EC073.8090006@xxxxxxxxxxx> <534EC173.7010903@xxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Apr 16, 2014 at 12:44:19PM -0500, Eric Sandeen wrote:
> return is not a function.  "return(EIO);" is silly;
> "return (EIO);" moreso.  return is not a function.
> Nuke the pointless parens.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] xfs: clean up return handling, Eric Sandeen [PATCH 1/2] xfs: return is not a function, Eric Sandeen Re: [PATCH 1/2] xfs: return is not a function, Christoph Hellwig <= [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Eric Sandeen Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Christoph Hellwig Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Eric Sandeen Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Eric Sandeen Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Dave Chinner Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Steven Rostedt Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Dave Chinner Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Dave Chinner Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Christoph Hellwig Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Dave Chinner

Previous by Date:	Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro, Christoph Hellwig
Next by Date:	Re: [PATCH 1/9] db: don't claim unchecked CRCs are correct, Christoph Hellwig
Previous by Thread:	[PATCH 1/2] xfs: return is not a function, Eric Sandeen
Next by Thread:	[PATCH 2/2] xfs: Nuke XFS_ERROR macro, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]