xfs
[Top] [All Lists]

Re: [PATCH] ext4: fix check for zero range support in ext4/001

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH] ext4: fix check for zero range support in ext4/001
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Sat, 19 Apr 2014 17:42:03 -0400
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=ef5046eb; t=1397943723; bh=B6/2WyaOX4rU2Q7JR9I23BGEDtqBG/93lpkH3u/IRpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xo5erak9C7Y6PbUbNyQwkolglyIs//GsvIMc0+Dd0zvYyVuIXO8hxhDp3ioDSRR3+ 1+5aqkGdCb86hsxF6qLaB+QaSTz6XSthD17h4ltjYy/G+bZRsRNTXfEwM2GK3VNo81 7KagzclNbx4ozaEZRQn+lKnLEClKksrFEbONc5JI=
In-reply-to: <20140419190815.GB2116@wallace>
References: <20140419190815.GB2116@wallace>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sat, Apr 19, 2014 at 03:08:15PM -0400, Eric Whitney wrote:
> Ext4/001 fails when run on a file system that does not support byte range
> zeroing.  For example, an EOPNOTSUPP failure occurs when the test is run
> on a pre-3.15 extent-mapped file system.  The code in the test intended
> to prevent this contains an apparent typo that results in a check for
> fallocate() rather than zero range support.
> 
> Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>

LGTM

Reviewed-by: "Theodore Ts'o" <tytso@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>