xfs
[Top] [All Lists]

Re: [PATCH] generic: fix check for zero range support in generic/009

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH] generic: fix check for zero range support in generic/009
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Sat, 19 Apr 2014 17:41:49 -0400
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=ef5046eb; t=1397943709; bh=dShqz82Vi8dy+mq0mKJN7XEzLa/9pOBvVcQAqhfQSkA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y73cT6DRPb+RmCtPUIJEinvAD1pCHcuweUyQ8ZW990gFuEJFaszIIvnLCfpE0dTeY axImYArALrsLfppclj9SOBl84BLNkVTuf/w7se6L+a9Bx7octDzjJwTFxDnlirvh0f 2/urOShIqM3qU4towKeBS9UBvKEh6+ghR9vo311U=
In-reply-to: <20140419190524.GA2116@wallace>
References: <20140419190524.GA2116@wallace>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sat, Apr 19, 2014 at 03:05:24PM -0400, Eric Whitney wrote:
> Generic/001 fails when run on a file system that does not support byte range
> zeroing.  For example, an EOPNOTSUPP failure occurs when the test is run
> on a pre-3.15 extent-mapped file system.  The code in the test intended
> to prevent this contains an apparent typo that results in a check for
> fallocate() rather than zero range support.
> 
> Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>

LGTM.

Reviewed-by: "Theodore Ts'o" <tytso@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>