xfs
[Top] [All Lists]

Re: [PATCH] xfstests: log running test to dmesg

To: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: log running test to dmesg
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 16 Apr 2014 20:43:25 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140416234027.GR15995@dastard>
References: <534EF81D.20205@xxxxxxxxxx> <20140416234027.GR15995@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 4/16/14, 6:40 PM, Dave Chinner wrote:
> On Wed, Apr 16, 2014 at 04:37:33PM -0500, Eric Sandeen wrote:
>> We already log the running test to system logs via "logger"
>> but viro pointed out that we can use /dev/kmsg to insert it
>> into dmesg as well.  When looking at the serial console that
>> could be pretty useful.
>>
>> Thanks to viro for the test -w suggestion too.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> ---
>>
>> diff --git a/check b/check
>> index 268417c..09b2320 100755
>> --- a/check
>> +++ b/check
>> @@ -457,6 +457,7 @@ do
>>      $timestamp && echo -n " ["`date "+%T"`"]"
>>      [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>>      $LOGGER_PROG "run xfstest $seqnum"
>> +    test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>>      ./$seq >$tmp.rawout 2>&1
>>      sts=$?
>>      $timestamp && _timestamp
> 
> Might it be worthwhile adding a "_log" function that can take an
> arbitrary string so in future it is easy to add new log messages?

*shrug* I guess... nobody logs anything but here, today...

-Eric
 
> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>