Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 4/16/14, 12:51 PM, Christoph Hellwig wrote:
> On Wed, Apr 16, 2014 at 12:48:50PM -0500, Eric Sandeen wrote:
>> XFS_ERROR was designed long ago to trap return values,
>> but it's not runtime configurable, it's not consistently used,
>> and we can do the same thing today with systemtap, using
>> something like:
>>
>> probe module("xfs").function("xfs_*").return { if (@defined($return) && 
>> $return == VALUE) { ... } }
> 
> Gives me a version just using ftrace, or at least a kprobes based module
> that we can merged in the kernel tree and this would be fine for me.
> 
> Requiring a massive blob of questionable out of tree module code and a
> compiler is an absolute no-go.

Ok, fair point.
 
> NAK for now.

Even if we don't have a replacement, I have yet to find anyone who has
ever used it...

Anyway, I'll look into options besides systemtap.

Thanks,
-Eric