[Top] [All Lists]

Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Apr 2014 10:51:17 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <534EC282.7010905@xxxxxxxxxxx>
References: <534EC073.8090006@xxxxxxxxxxx> <534EC282.7010905@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 16, 2014 at 12:48:50PM -0500, Eric Sandeen wrote:
> XFS_ERROR was designed long ago to trap return values,
> but it's not runtime configurable, it's not consistently used,
> and we can do the same thing today with systemtap, using
> something like:
> probe module("xfs").function("xfs_*").return { if (@defined($return) && 
> $return == VALUE) { ... } }

Gives me a version just using ftrace, or at least a kprobes based module
that we can merged in the kernel tree and this would be fine for me.

Requiring a massive blob of questionable out of tree module code and a
compiler is an absolute no-go.

NAK for now.

<Prev in Thread] Current Thread [Next in Thread>