xfs
[Top] [All Lists]

Re: [PATCH] xfs: unmount does not wait for shutdown during unmount

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: unmount does not wait for shutdown during unmount
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Apr 2014 07:27:48 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, bob.mastors@xxxxxxxxxxxxx, snitzer@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140415145924.GA3470@xxxxxxxxxxxxxx>
References: <1397104955-7247-1-git-send-email-david@xxxxxxxxxxxxx> <20140414192824.GC62307@xxxxxxxxxxxxxxx> <20140415021546.GD31578@dastard> <20140415145924.GA3470@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 15, 2014 at 10:59:25AM -0400, Brian Foster wrote:
> Yeah, I noticed that the completion wouldn't fire as is since it appears
> that doesn't occur if a b_iodone call is provided. FWIW, the thought
> process was more to inherit the use of b_iowait in xlog_iodone().

That doesn't mean the b_iodone callback couldn't do the wakeup on
b_iowait.

I have to say it makes me a bit uneasy that we had to find this
race the hard way for the superblock, and now for the logbufs again.

Seems like all other uncached buffers are only read and written
synchronously, so for this should be the last issue, but I fear about
new ones showing up in the future and would prefer a more general
solution.

Reluctantly:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>