xfs
[Top] [All Lists]

Re: [PATCH 7/9] repair: remove more dirv1 leftovers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/9] repair: remove more dirv1 leftovers
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Wed, 16 Apr 2014 09:23:34 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397550301-31883-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1397550301-31883-1-git-send-email-david@xxxxxxxxxxxxx> <1397550301-31883-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 15, 2014 at 06:24:59PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> get_bmapi() and it's children were only called by dirv1 code. There
> are no current callers, so remove them.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  repair/dinode.c | 239 
> --------------------------------------------------------
>  repair/dinode.h |   6 --
>  2 files changed, 245 deletions(-)
> 
> diff --git a/repair/dinode.c b/repair/dinode.c
> index 48f17ac..b086bec 100644
> --- a/repair/dinode.c
> +++ b/repair/dinode.c
...
> -xfs_dfsbno_t
> -get_bmapi(xfs_mount_t *mp, xfs_dinode_t *dino_p,
> -             xfs_ino_t ino_num, xfs_dfiloff_t bno, int whichfork)
> -{
> -     xfs_dfsbno_t            fsbno;
> -
> -     switch (XFS_DFORK_FORMAT(dino_p, whichfork)) {
> -     case XFS_DINODE_FMT_EXTENTS:
> -             fsbno = getfunc_extlist(mp, ino_num, dino_p, bno, whichfork);
> -             break;
> -     case XFS_DINODE_FMT_BTREE:
> -             fsbno = getfunc_btree(mp, ino_num, dino_p, bno, whichfork);
> -             break;
> -     case XFS_DINODE_FMT_LOCAL:
> -             do_error(_("get_bmapi() called for local inode %" PRIu64 "\n"),
> -                     ino_num);

I'm not quite familiar with how we manage the .po translation files, but
FYI this string appears in a couple of them. Not sure whether there is
value in keeping the translation around. The string does include the
specific function name.

Brian

> -             fsbno = NULLDFSBNO;
> -             break;
> -     default:
> -             /*
> -              * shouldn't happen
> -              */
> -             do_error(_("bad inode format for inode %" PRIu64 "\n"), 
> ino_num);
> -             fsbno = NULLDFSBNO;
> -     }
> -
> -     return(fsbno);
> -}
> -
> -/*
>   * higher level inode processing stuff starts here:
>   * first, one utility routine for each type of inode
>   */
> diff --git a/repair/dinode.h b/repair/dinode.h
> index 5ee51ca..80f3e4e 100644
> --- a/repair/dinode.h
> +++ b/repair/dinode.h
> @@ -119,12 +119,6 @@ get_agino_buf(xfs_mount_t        *mp,
>               xfs_agino_t     agino,
>               xfs_dinode_t    **dipp);
>  
> -xfs_dfsbno_t
> -get_bmapi(xfs_mount_t                *mp,
> -             xfs_dinode_t    *dip,
> -             xfs_ino_t       ino_num,
> -             xfs_dfiloff_t   bno,
> -             int             whichfork );
>  
>  void dinode_bmbt_translation_init(void);
>  char * get_forkname(int whichfork);
> -- 
> 1.9.0
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>