xfs
[Top] [All Lists]

Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate
From: LukÃÅ Czerner <lukas@xxxxxxxx>
Date: Tue, 15 Apr 2014 21:57:41 +0200
Cc: LukÃÅ Czerner <lczerner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140415194004.GG4456@xxxxxxxxx>
References: <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-3-git-send-email-lczerner@xxxxxxxxxx> <20140412152117.GB18047@xxxxxxxxxxxxx> <alpine.LFD.2.00.1404151510150.2146@xxxxxxxxxxxxxxxxxxxxx> <20140415153643.GB4456@xxxxxxxxx> <alpine.LFD.2.00.1404151808440.2146@xxxxxxxxxxxxxxxxxxxxx> <20140415194004.GG4456@xxxxxxxxx>
User-agent: Internet Messaging Program (IMP) H4 (5.0.18)
Yes, please drop the patch #4 since it requires different solution, I
do not think it's critical enough to have partial solution and it has
been that way for a long time. We can fix it later.

Thanks!
-Lukas


Theodore Ts'o <tytso@xxxxxxx> wrote:

On Tue, Apr 15, 2014 at 06:09:34PM +0200, LukÃÅ Czerner wrote:

Ok, I'll run some tests and resend it right away without the patch
#4.

Thanks!  So should I drop patch #4 for now?  I don't think it does any
harm, and it does plug the hole somewhat, but Cristoph is right that
we still could have swapon racing with the fallocate.

                                           - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


<Prev in Thread] Current Thread [Next in Thread>