xfs
[Top] [All Lists]

Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Tue, 15 Apr 2014 15:40:04 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=ef5046eb; t=1397590804; bh=JyWUHRuOtHIWWAj+EIl3Dr7A8m5TV7qPlvG4Jtq8LcE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2EaovvmV1W0IcJZECWQx8pYa1eE8eAbMVJ/0GiAv6AjOrB4suUqJmbfqc0ajyLtV VLBG2u3yQ5nZL2p+OIw7OkW+3shn+5+aQNe9IzIf2i5bqqY8KWoUtLRhVzytZOlrLL C8cT0iEb1gwZseUvbh1xZhkdUKQxb9KOJGIfiNwA=
In-reply-to: <alpine.LFD.2.00.1404151808440.2146@xxxxxxxxxxxxxxxxxxxxx>
References: <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-3-git-send-email-lczerner@xxxxxxxxxx> <20140412152117.GB18047@xxxxxxxxxxxxx> <alpine.LFD.2.00.1404151510150.2146@xxxxxxxxxxxxxxxxxxxxx> <20140415153643.GB4456@xxxxxxxxx> <alpine.LFD.2.00.1404151808440.2146@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Apr 15, 2014 at 06:09:34PM +0200, LukÃÅ Czerner wrote:
> 
> Ok, I'll run some tests and resend it right away without the patch
> #4.

Thanks!  So should I drop patch #4 for now?  I don't think it does any
harm, and it does plug the hole somewhat, but Cristoph is right that
we still could have swapon racing with the fallocate.

                                           - Ted

<Prev in Thread] Current Thread [Next in Thread>