xfs
[Top] [All Lists]

[PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only fil

To: linux-fsdevel@xxxxxxxxxxxxxxx
Subject: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file
From: Lukas Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 15 Apr 2014 18:41:15 +0200
Cc: linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Lukas Czerner <lczerner@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397580076-19826-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1397580076-19826-1-git-send-email-lczerner@xxxxxxxxxx>
Currently punch hole and collapse range fallocate operation are not
allowed on append only file. This should be case for zero range as well.
Fix it by allowing only pure fallocate (possibly with keep size set).

Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
---
v2: Change the condition to be future proof as suggested by hch

 fs/open.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 631aea81..fe48b2f 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -254,11 +254,9 @@ int do_fallocate(struct file *file, int mode, loff_t 
offset, loff_t len)
                return -EBADF;
 
        /*
-        * It's not possible to punch hole or perform collapse range
-        * on append only file
+        * We can only allow pure fallocate on append only files
         */
-       if (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE)
-           && IS_APPEND(inode))
+       if (mode & ~FALLOC_FL_KEEP_SIZE && IS_APPEND(inode))
                return -EPERM;
 
        if (IS_IMMUTABLE(inode))
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>