xfs
[Top] [All Lists]

Re: [PATCH 4/4] fs: Disallow all fallocate operation on active swapfile

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] fs: Disallow all fallocate operation on active swapfile
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 15 Apr 2014 15:19:47 +0200 (CEST)
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140412152225.GC18047@xxxxxxxxxxxxx>
References: <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-4-git-send-email-lczerner@xxxxxxxxxx> <20140412152225.GC18047@xxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Sat, 12 Apr 2014, Christoph Hellwig wrote:

> Date: Sat, 12 Apr 2014 08:22:25 -0700
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx,
>     linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
> Subject: Re: [PATCH 4/4] fs: Disallow all fallocate operation on active
>     swapfile
> 
> Given that the earlier patches were about races - what protects us
> from swapon racing with the check outside the filesystem locks?
> 

That would be fairies :) This patch is obviously wrong so I'll drop
it and try to think about better way of dealing with this.

Thanks!
-Lukas

<Prev in Thread] Current Thread [Next in Thread>