Re: [PATCH 2/2] mkfs.xfs: prevent close(-1) on protofile error path

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

My previous cleanups introduced this; in the case where
fd=open() failed, the out_fail: path would try to close(-1).

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

diff --git a/mkfs/proto.c b/mkfs/proto.c
index 308325b..5a47e27 100644
--- a/mkfs/proto.c
+++ b/mkfs/proto.c
@@ -84,7 +84,8 @@ setup_proto(
        return buf;
 
 out_fail:
-       close(fd);
+       if (fd >= 0)
+               close(fd);
        free(buf);
        exit(1);
 }