[Top] [All Lists]

Re: [PATCH] xfsprogs: fix xfs_logprint EFI entry split on log buffer

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix xfs_logprint EFI entry split on log buffer
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 14 Apr 2014 11:42:12 +1000
Cc: XFS Filesystem <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140409210048.859660076@xxxxxxx>
References: <20140409210013.095709266@xxxxxxx> <20140409210048.859660076@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 09, 2014 at 04:00:14PM -0500, Mark Tinguely wrote:
> xfs_logprint does not correctly handle EFI entries that
> are split across two log buffers. xfs_efi_copy_format()
> falsely interrupts the truncated size of the split entry
> as being a corrupt entry.
> If the first log entry has enough information, namely the
> number of extents in the entry and the identifier, then
> display this information and a warning that this entry is
> truncated. Otherwise, if there is not enough information in
> the first log buffer, then print a message that the EFI decode
> was not possible. These messages are similar to split inode
> entries.
> Example of a continued entry:
> Oper (336): tid: f214bdb  len: 44  clientid: TRANS  flags: CONTINUE
> EFI:  #regs: 1    num_extents: 2  id: 0xffff880804f63900
> EFI free extent data skipped (CONTINUE set, no space)
> Reported-by: Michael L. Semon <mlsemon35@xxxxxxxxx>
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>