xfs
[Top] [All Lists]

Re: [PATCH] generic: add fallocate() checks to generic/300

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH] generic: add fallocate() checks to generic/300
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 14 Apr 2014 10:29:43 +1000
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140411214307.GC10174@wallace>
References: <20140411214307.GC10174@wallace>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Apr 11, 2014 at 05:43:07PM -0400, Eric Whitney wrote:
> Generic/300 fails when run on a test filesystem that does not support
> fallocate(). It uses fio's falloc ioengine to generate part of its I/O
> load and both allocates blocks and punches holes.  This causes EOPNOTSUPP
> failures when the test is run on indirect block-mapped ext4 filesystems
> or pre-3.14 ext4 filesystems created with bigalloc.
> 
> Verify that the test filesystem supports fallocate() before proceeding
> with the test, checking for both block allocation and hole punching
> capabilities.  Also, delete any pre-existing test output.
> 
> Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>

Makes sense. Same for the second patch, too.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>