xfs
[Top] [All Lists]

Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 12 Apr 2014 08:21:17 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397242665-2183-3-git-send-email-lczerner@xxxxxxxxxx>
References: <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-3-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good, but the subject line is misleading, it should read something
like:

"fs: move falloc collapse range check into the filesystem methods"

Might also be worth mentioning that size checks for the other modes
are in the filesystems in the the long description.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>