[Top] [All Lists]

Re: [PATCH 4/4] fs: Disallow all fallocate operation on active swapfile

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 4/4] fs: Disallow all fallocate operation on active swapfile
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Sat, 12 Apr 2014 10:06:33 -0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1397311593; bh=9ijiiyCUT3xtHgd2TWK/SXvYJ6kz+cs8U6yoa1ZxcmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g+Yb+/ngvRx9/a2pDUQ7nIXhdm1i8gllIvpYKrd7CcD61PM284Yc2PFAd98Jsada6 FoaHsdrr0IwdKQ0BAzZQtv5UmJDtWriK+QorPVp2eWesMXjEq/pqV8GnUstEx76qWV WJu/G+ZRf3cvFUe0l1z50e+KfKUK1+bzD4vVFzdI=
In-reply-to: <1397242665-2183-4-git-send-email-lczerner@xxxxxxxxxx>
References: <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-4-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Apr 11, 2014 at 08:57:45PM +0200, Lukas Czerner wrote:
> Currently some file system have IS_SWAPFILE check in their fallocate
> implementations and some does not. However we should really prevent any
> fallocate operation on swapfile so move the check to vfs and remove the
> redundant checks from the file systems fallocate implementations.
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> ---
>  fs/ceph/file.c    | 3 ---
>  fs/ext4/extents.c | 5 -----
>  fs/ext4/inode.c   | 5 -----
>  fs/open.c         | 7 +++++++
>  4 files changed, 7 insertions(+), 13 deletions(-)

Thanks, applied.  Again, if anyone has an objections with my carrying
these patches in the ext4 tree and pushing them to Linus shortly after
-rc1, please let me know.

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>