| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] generic: add fallocate() check to generic/311 |
| From: | Eric Whitney <enwlinux@xxxxxxxxx> |
| Date: | Fri, 11 Apr 2014 17:46:23 -0400 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=hnTYMSsFYzfQS5YbnxMWKeiXGYeTh52PjC1LXRc+X3A=; b=PEzLd9aIYDogdGvjaFPwed0IV6dE9MLjJ3+L91DvIGQnGCLljRG34W+56RxCbl1sWT 8b7rlb/MPLkkqQi9zzYdV51BSHNzpYSM9vAAI/I4OVbd74wR5tR4QLia4KtL5yNQSOja yP2aOhEKicF8E77kS/n/F7dw8kAogf3qOUj0RTJTPgNAQW+5T+PmgxOCYAvi6DvZKGwD sicq//Bo2f1cytnEKoygbSneF2bdtdlFEYhecIHjIWZXQGT7sr4HiLVNVsOi48DI2eCf 5RbmZpIlsFFI/aSk3HCV25smJhn3LYxWR9GJdutld6hW92p/iw+4M0XNK8cFJM7bKBJ0 vq0g== |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Generic/311 fails when run on a test filesystem that does not support fallocate(). Its I/O load is produced by fsync-tester, which uses fallocate() system calls to allocate blocks for some of its test cases. This causes EOPNOTSUPP failures when the test is run on indirect block-mapped ext4 filesystems. Verify that the test filesystem supports fallocate() before proceeding with the test, checking for block allocation capabilities. Also, fix a minor error message typo. Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> --- tests/generic/311 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) mode change 100644 => 100755 tests/generic/311 diff --git a/tests/generic/311 b/tests/generic/311 old mode 100644 new mode 100755 index 6802a96..284b59d --- a/tests/generic/311 +++ b/tests/generic/311 @@ -57,7 +57,11 @@ _need_to_be_root _require_scratch _require_dm_flakey -[ -x $here/src/fsync-tester ] || _notrun "fsync-tester not build" +# xfs_io is not required for this test, but it's the best way to verify +# the test system supports fallocate() for allocation +_require_xfs_io_falloc + +[ -x $here/src/fsync-tester ] || _notrun "fsync-tester not built" rm -f $seqres.full SEED=1 -- 1.8.3.2 |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] generic: add fallocate() checks to generic/300, Eric Whitney |
|---|---|
| Next by Date: | [PATCH 03/14 V2] xfsprogs: trivial buffer frees on error paths, Eric Sandeen |
| Previous by Thread: | [PATCH] generic: add fallocate() checks to generic/300, Eric Whitney |
| Next by Thread: | filestream allocator rewrite, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |