| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: wrong error sign conversion during failed DIO writes |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 11 Apr 2014 00:39:39 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1397191575-2144-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1397191575-2144-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 11, 2014 at 02:46:15PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > We negate the error value being returned from a generic function > incorrectly. The code path that it is running in returned negative > errors, so there is no need to negate it to get the correct error > signs here. > > This was uncovered by generic/019. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Christoph Hellwig |
|---|---|
| Next by Date: | REAL, ED & SOP |
| Previous by Thread: | [PATCH] xfs: wrong error sign conversion during failed DIO writes, Dave Chinner |
| Next by Thread: | REAL, ED & SOP |
| Indexes: | [Date] [Thread] [Top] [All Lists] |