xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix specifying configuration value with equality s

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix specifying configuration value with equality sign
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 11 Apr 2014 10:14:10 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397123737-3478-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1397123737-3478-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 10, 2014 at 11:55:37AM +0200, Lukas Czerner wrote:
> Currently there is a problem with parse_config_section() when the
> configuration value contains equality sign like this for example:
> 
> MOUNT_OPTIONS="-o data=journal"
> 
> the result will be
> 
> export MOUNT_OPTIONS="-o data="journal"
> 
> which is not going to work. The reason is that the expression used to
> parse the configuration options uses greedy matching '.*'. Fix this by
> using non greedy expression to match the first equality sign '[^=]'.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

It would probably be a good idea to comment what the sed line noise
is actually doing, so it's easier to understand in future...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>