xfs
[Top] [All Lists]

Re: [PATCH] ext4/306: disable 64bit feature too

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] ext4/306: disable 64bit feature too
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 11 Apr 2014 10:12:35 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1397044147-15727-1-git-send-email-eguan@xxxxxxxxxx>
References: <1397044147-15727-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 09, 2014 at 07:49:07PM +0800, Eryu Guan wrote:
> mke2fs ext4 without extent feature will fail if 64bit feature is
> enabled in mke2fs.conf
> 
> mke2fs 1.42.9 (28-Dec-2013)
> Extents MUST be enabled for a 64-bit filesystem.  Pass -O extents to rectify.
> 
> So disable 64bit feature together with extent explicitly.
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
>  tests/ext4/306 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/306 b/tests/ext4/306
> index 9559cf2..fd50b0e 100755
> --- a/tests/ext4/306
> +++ b/tests/ext4/306
> @@ -48,7 +48,7 @@ _require_scratch
>  rm -f $seqres.full
>  
>  # Make a small ext4 fs with extents disabled & mount it
> -yes | mkfs.ext4 -O ^extents $SCRATCH_DEV 512m >> $seqres.full 2>&1
> +yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1
>  _scratch_mount || _fail "couldn't mount fs"
>  
>  # Create a small non-extent-based file
> -- 
> 1.9.0

Looks fine to me, but you should CC ext4 test changes to
linux-ext4@xxxxxxxxxxxxxxx as well so that the ext4 developers can
review such changes are well...

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>