xfs
[Top] [All Lists]

Re: [PATCH 15/14] xfs_io: free memory on error path exit from bmap_f()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 15/14] xfs_io: free memory on error path exit from bmap_f()
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 10 Apr 2014 08:38:56 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5345C751.8040803@xxxxxxxxxxx>
References: <1396999504-13769-1-git-send-email-sandeen@xxxxxxxxxx> <5345C751.8040803@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/09/14 17:18, Eric Sandeen wrote:
If realloc() fails, the memory it was trying to realloc remains;
free it on the error path.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

diff --git a/io/bmap.c b/io/bmap.c
index a78cbb1..8e5d75e 100644
--- a/io/bmap.c
+++ b/io/bmap.c
@@ -227,6 +227,7 @@ bmap_f(
                                fprintf(stderr,
                                        _("%s: cannot realloc %d bytes\n"),
                                        progname, (int)(map_size*sizeof(*map)));
+                               free(map);
                                exitcode = 1;
                                return 0;
                        }


Didn't it get into this block by comparing map to NULL?

--Mark.

<Prev in Thread] Current Thread [Next in Thread>