[Top] [All Lists]

generic/204: correct log size for XFS

To: xfs@xxxxxxxxxxx
Subject: generic/204: correct log size for XFS
From: alexander.tsvetkov@xxxxxxxxxx
Date: Thu, 10 Apr 2014 14:28:41 +0400
Delivered-to: xfs@xxxxxxxxxxx
Organization: Oracle Corporation
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
generic/204 fails on device with Advanced Format of 4096 bytes per
physical sector and when partition
starts at the 4K boundary.In this case
sector/block size will be of 4096 bytes size and _scratch_mkfs_sized
fails because mkfs reports that 5Mb log size is not enough to create a filesystem,
for example attempt to make filesystem on such partition: 

mkfs.xfs -f -bsize=4096 -l size=5m -d size=109051904 /dev/sdb2"

results to:

"log size 1280 blocks too small, minimum size is 1605 blocks"

and generic/204
fails with ENOSPC before it has finished creating the necessary files:

"QA output created by 204
./tests/generic/204: line 86: echo: write error: No space left on device

Log size of 7Mb
is enough to make filesytem and pass this test.

diff --git a/tests/generic/204 b/tests/generic/204
index 13a762a..4ebab26 100755
--- a/tests/generic/204
+++ b/tests/generic/204
@@ -53,9 +53,9 @@ _scratch_mkfs 2> /dev/null | _filter_mkfs 2> $tmp.mkfs > /dev/null

 # For xfs, we need to handle the different default log sizes that different
 # versions of mkfs create. All should be valid with a 5MB log, so use that.
-[ $FSTYP = "xfs" ] && MKFS_OPTIONS="$MKFS_OPTIONS -l size=5m"
+[ $FSTYP = "xfs" ] && MKFS_OPTIONS="$MKFS_OPTIONS -l size=7m"

-SIZE=`expr 104 \* 1024 \* 1024`
+SIZE=`expr 106 \* 1024 \* 1024`
 _scratch_mkfs_sized $SIZE $dbsize 2> /dev/null \
                | _filter_mkfs 2> $tmp.mkfs > /dev/null
<Prev in Thread] Current Thread [Next in Thread>