xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: remove write-only assignments

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: remove write-only assignments
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 09 Apr 2014 12:50:12 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53457FAF.7060208@xxxxxxxxxx>
References: <53457FAF.7060208@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/09/14 12:13, Eric Sandeen wrote:
There are many instances where variable assignments are made,
but never read (or are re-assigned before they are read).
The Clang static analyzer finds these.

Here's a chunk of what I think are trivial removals of such
assignments; other detections point to more serious problems
(or are shared w/ kernel code so should probably be fixed there
first).

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

These may be a bit tedious to review; perhaps graphical diff
w/ more context would help in some cases?


This patch length is not so bad. Light reading with lunch. They all look good to me.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>